Fix CI #775
Merged
Fix CI #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Aug 24, 2023
| @@ -72,14 +72,13 @@ | |||
| "ember-cli-babel": "^7.26.6", | |||
| "ember-cli-dependency-checker": "^3.2.0", | |||
| "ember-cli-inject-live-reload": "^2.1.0", | |||
| "ember-export-application-global": "^2.0.1", | |||
There was a problem hiding this comment.
Doesn't work in Ember v5.
bertdeblock
commented
Aug 24, 2023
| "ember-load-initializers": "^2.1.1", | ||
| "ember-maybe-import-regenerator": "^0.1.6", | ||
| "ember-qunit": "^5.1.4", | ||
| "ember-resolver": "^8.0.2", | ||
| "ember-source": "~3.28.0", | ||
| "ember-source-channel-url": "^3.0.0", | ||
| "ember-styleguide": "^5.0.0", | ||
| "ember-styleguide": "^8.4.0", |
There was a problem hiding this comment.
Older version was breaking the build with newer Ember versions. Using an in-repo / internal addon might be better? Feels fragile.
bertdeblock
force-pushed
the
fix-ci
branch
2 times, most recently
from
4171425
to
01d6672
Compare
bertdeblock
commented
Aug 24, 2023
| @@ -106,6 +105,9 @@ | |||
| "publishConfig": { | |||
| "registry": "https://registry.npmjs.org" | |||
| }, | |||
| "ember": { | |||
| "edition": "octane" | |||
There was a problem hiding this comment.
Required in newer Ember versions.
NullVoxPopuli
approved these changes
Aug 24, 2023
void-mAlex
approved these changes
Aug 24, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.