-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Fork of Pixelik's PR to fix tests and security issues #753
Open
Gaurav0
wants to merge
28
commits into
ember-cli:main
Choose a base branch
from
Gaurav0:DazzlingFugu/chore/ember-5-compatible
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DO NOT MERGE] Fork of Pixelik's PR to fix tests and security issues #753
Gaurav0
wants to merge
28
commits into
ember-cli:main
from
Gaurav0:DazzlingFugu/chore/ember-5-compatible
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- runs yarn lint:fix
Gaurav0
changed the title
[DO NOT MERGE] Fork of Pixelnik's PR to fix tests and security issues
[DO NOT MERGE] Fork of Pixelik's PR to fix tests and security issues
Nov 5, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I do not expect this to be merged like this but I am releasing it to hopefully jog someone else into action, get feedback, and possibly be helpful in getting people unblocked with their apps. ember-fetch is a dependency of many addons. This PR is built on other PRs that have not been merged.
Depends on gorner/sourcemap-validator#1 and tomdale/ember-cli-addon-tests#223
This fork takes #741 and fixes all tests and security issues found in dependencies (as shown by running
yarn audit --groups dependencies
)You can see tests passing here: Gaurav0#1
cc/ @Pixelik @NullVoxPopuli