adds skipPrettier and self closing

README.md

@@ -77,13 +77,49 @@ You can also disable the conversion of the built-in components `{{link-to}}`, `{
 }
 ```
 
+You can also disable the final **Prettier** formatting by adding `skipPrettier` as follows:
+
+**config/anglebrackets-codemod-config.json**
+
+```js
+{
+  "helpers": [],
+  "skipPrettier": true
+}
+```
+By disabling Prettier, oddly formatted `hbs` files will remain (somewhat) unchanged:
+
+#### From
+```hbs
+{{#bs-button-group
+  value=buttonGroupValue
+  type="checkbox"
+  onChange=(action (mut buttonGroupValue)) as |bg|}}
+			{{#bg.button value=1}}1{{/bg.button}}
+  {{#bg.button value=2}}2{{/bg.button}}
+  			{{#bg.button value=3}}3{{/bg.button}}
+				{{#bg.button value=3}}3{{/bg.button}}
+{{/bs-button-group}}
+```
+
+#### To
+```hbs
+<BsButtonGroup @value={{buttonGroupValue}} @type="checkbox" @onChange={{action (mut buttonGroupValue)}} as |bg|>
+			<bg.button @value={{1}}>1</bg.button>
+  <bg.button @value={{2}}>2</bg.button>
+  			<bg.button @value={{3}}>3</bg.button>
+				<bg.button @value={{3}}>3</bg.button>
+</BsButtonGroup>
+```
+
 You can execute the codemod with custom configuration by specifying a `--config` command line option as follows:
 
 ```sh
 $ cd my-ember-app-or-addon
 $ npx ember-angle-brackets-codemod angle-brackets app/templates --config ./config/anglebrackets-codemod-config.json
 ```
 
+### Getting a list of helpers
 To get a list of helpers in your app you can do this in the Developer Console in your browser inside of your app:
 ```js
 var componentLikeHelpers = Object.keys(require.entries)

transforms/angle-brackets/__testfixtures__/custom-options.config.json

@@ -1,4 +1,5 @@
 {
   "helpers": ["some-helper1", "some-helper2", "some-helper3"],
-  "skipBuiltInComponents": true
+  "skipBuiltInComponents": true,
+  "skipPrettier": true
 }

transforms/angle-brackets/__testfixtures__/custom-options.input.hbs

@@ -4,3 +4,26 @@
 {{link-to "Title" "some.route"}}
 {{textarea value=this.model.body}}
 {{input type="checkbox" name="email-opt-in" checked=this.model.emailPreference}}
+
+{{site-header user=this.user class=(if this.user.isAdmin "admin")}}
+{{#super-select selected=this.user.country as |s|}}
+  {{#each this.availableCountries as |country|}}
+    {{#s.option value=country}}{{country.name}}{{/s.option}}
+  {{/each}}
+{{/super-select}}
+
+{{#bs-button-group
+  value=buttonGroupValue
+  type="checkbox"
+  onChange=(action (mut buttonGroupValue)) as |bg|}}
+			{{#bg.button value=1}}1{{/bg.button}}
+  {{#bg.button value=2}}2{{/bg.button}}
+  			{{#bg.button value=3}}3{{/bg.button}}
+				{{#bg.button value=3}}3{{/bg.button}}
+{{/bs-button-group}}
+
+someFunction({
+  {{#unless installationIsAnonymous}}
+    console.log("hi");
+  {{/unless}}
+});

transforms/angle-brackets/__testfixtures__/custom-options.output.hbs

@@ -4,3 +4,23 @@
 {{link-to "Title" "some.route"}}
 {{textarea value=this.model.body}}
 {{input type="checkbox" name="email-opt-in" checked=this.model.emailPreference}}
+
+<SiteHeader @user={{this.user}} class={{if this.user.isAdmin "admin"}} />
+<SuperSelect @selected={{this.user.country}} as |s|>
+  {{#each this.availableCountries as |country|}}
+    <s.option @value={{country}}>{{country.name}}</s.option>
+  {{/each}}
+</SuperSelect>
+
+<BsButtonGroup @value={{buttonGroupValue}} @type="checkbox" @onChange={{action (mut buttonGroupValue)}} as |bg|>
+			<bg.button @value={{1}}>1</bg.button>
+  <bg.button @value={{2}}>2</bg.button>
+  			<bg.button @value={{3}}>3</bg.button>
+				<bg.button @value={{3}}>3</bg.button>
+</BsButtonGroup>
+
+someFunction({
+  {{#unless installationIsAnonymous}}
+    console.log("hi");
+  {{/unless}}
+});

transforms/angle-brackets/transforms/angle-brackets-syntax.js

@@ -9,6 +9,7 @@ class Config {
   constructor(options) {
     this.helpers = [];
     this.skipBuiltInComponents = false;
+    this.skipPrettier = false;
 
     if (options.config) {
       let filePath = path.join(process.cwd(), options.config);
@@ -19,6 +20,7 @@ class Config {
       }
 
       this.skipBuiltInComponents = !!config.skipBuiltInComponents;
+      this.skipPrettier = !!config.skipPrettier;
     }
   }
 }
@@ -350,8 +352,12 @@ module.exports = function(fileInfo, api, options) {
     let attributes;
     let children = node.program ? node.program.body : undefined;
     let blockParams = node.program ? node.program.blockParams : undefined;
+    let selfClosing = node.type !== 'BlockStatement';
 
-    if(tagName === 'link-to') {
+    if (tagName === 'link-to') {
+
+      selfClosing = false;
+
       if (node.type === 'MustacheStatement') {
         let params = node.params;
         let textParam = params.shift(); //the first param becomes the block content
@@ -373,10 +379,10 @@ module.exports = function(fileInfo, api, options) {
       attributes = transformNodeAttributes(node);
     }
 
-    return b.element(newTagName, {
+    return b.element({ name: newTagName, selfClosing }, {
       attrs: attributes,
       children,
-      blockParams
+      blockParams,
     });
   };
 
@@ -411,5 +417,5 @@ module.exports = function(fileInfo, api, options) {
 
   let uglySource = glimmer.print(ast).replace(attrEqualEmptyString,"");
   let dataOk = uglySource.replace(dataEqualsNoValue, "$1");
-  return prettier.format(dataOk, { parser: "glimmer" });
+  return config.skipPrettier ? dataOk : prettier.format(dataOk, { parser: "glimmer" });
 };