Increment latest schema version to 5 #822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xg-wang
commented
Apr 7, 2021
| @@ -4,6 +4,30 @@ | |||
| "fastboot": { | |||
| "schemaVersion": 5, | |||
| "moduleWhitelist": [], | |||
| "htmlEntrypoint": "index.html" | |||
| "htmlEntrypoint": "index.html", | |||
| "config": { | |||
There was a problem hiding this comment.
I haven't thought about this in a while but that seems fine to me.
There was a problem hiding this comment.
Done in latest commit. v5 schema after the fix is backwards compatible to embroider build
|
We should also ignore certain scripts like https://github.com/embroider-build/embroider/pull/455/files |
xg-wang
force-pushed
the
increment-schema
branch
2 times, most recently
from
00dc159 to
9068d29
Compare
xg-wang
commented
Apr 9, 2021
| @@ -455,18 +455,4 @@ describe('FastBoot', function() { | |||
| usedPrebuiltSandbox: true, | |||
| }); | |||
| }); | |||
|
|
|||
| it('htmlEntrypoint works', function() { | |||
There was a problem hiding this comment.
Moved to test-packages/integration-tests/test/basic-test.js
xg-wang
force-pushed
the
increment-schema
branch
3 times, most recently
from
ff128a5 to
78c8ec2
Compare
xg-wang
force-pushed
the
increment-schema
branch
from
192d5ea to
f2a4ec1
Compare
xg-wang
force-pushed
the
increment-schema
branch
3 times, most recently
from
ab0945f to
032b7c7
Compare
When using custom rootURL specified in environment.js, the fastboot-script is still having relative path to local dist path, not containing rootURL path. The fastboot-script should not be ignored.
xg-wang
force-pushed
the
increment-schema
branch
from
032b7c7 to
9d8e702
Compare
This was referenced Aug 22, 2021
xg-wang
force-pushed
the
increment-schema
branch
from
9d8e702 to
92bfac9
Compare
html-oriented manifest format ----------------------------- In the new schema format, which is defined in ember-fastboot/fastboot@3fd5bc9 the manifest is written into HTML and later extracted by fastboot on server side instead of previously reading from dist/package.json Note: The new schema in fastboot does not handle fastboot config https://github.com/ember-fastboot/ember-cli-fastboot/tree/e4d0b7c7bcdf82def0dc8726835b49d707673f41#providing-additional-config The support is added in the #854. Allow to require module path from whitelisted dependency ------------------------------------------------------- Incrementing schema to 5 also included the changes in schema 4 strictWhitelist See ember-fastboot/fastboot#200 Revert back to put config in dist/package.json add data-fastboot-ignore to unexpected files properly ignore files that should not execute in fastboot
xg-wang
force-pushed
the
increment-schema
branch
from
92bfac9 to
04f2181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html-oriented manifest format
In the new schema format, which is defined in
ember-fastboot/fastboot@3fd5bc9
the manifest is written into HTML and later extracted by fastboot on
server side instead of previously reading from dist/package.json
Note:
(1) fastboot config
The new schema in fastboot did not handle fastboot config
https://github.com/ember-fastboot/ember-cli-fastboot/tree/e4d0b7c7bcdf82def0dc8726835b49d707673f41#providing-additional-config
The support is added in the #854
The fastboot config meta has the name ending with
"config/fastboot-environement" to distinguish from regular
"config/environement" meta tags. If the new meta tags are not found,
which happens in embroider builds, we fallback to find regular meta
tags.
(2) keeping package.manifest
We cannot drop manifest field in the generated package.json until
broccoli-asset-rev support support reading config from html.
Allow to require module path from whitelisted dependency
Incrementing schema to 5 also included the changes in schema 4
strictWhitelist
See ember-fastboot/fastboot#200