Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to edit the current page on github #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sdhull
Copy link
Contributor

@sdhull sdhull commented Nov 29, 2018

Fixes #88

I basically emulated what is done on the Ember API docs pages, including copying the SVG pencil icon from those pages (though I stopped short of providing a popover with the title).

For example, this is the link from the Quickstart page.

screen shot 2018-11-28 at 8 35 40 pm

@sdhull
Copy link
Contributor Author

sdhull commented Nov 29, 2018

@kratiahuja @locks would be happy to change my approach or whatever you suggest 😄

Adding .nvmrc file is a noop for people who don't use nvm. But for those of use using nvm, declaring the target version of node for this project is very helpful.
Appropriates the pencil svg from Ember API docs. Sends users to the `/edit/master` github page for the current markdown file in a new window.
@locks locks self-assigned this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants