-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder.element(tagName)
throws an error in 6.x
#734
Comments
utilizing The global node on my machine is |
builder.element(tagName)
throws an error in 6.1.3builder.element(tagName)
throws an error in 6.x
I ran into this error while upgrading @glimmer/syntax a while ago here in template-recast: If we want to fix this, we should do it in @glimmer/syntax. As far as I remember it is a very light fix there (a missing ?). As a work around, you can provide an empty object as a second argument. |
@dcyriller confirm, it came into glimmer/syntax in this PR glimmerjs/glimmer-vm@8e11b91 we'd just need to have options = {} as the default here: https://github.com/glimmerjs/glimmer-vm/blob/a397f489047d89c4b2b6f4bfc4415e780c054b99/packages/%40glimmer/syntax/lib/v1/public-builders.ts#L205 |
Error:
Example Working in 5.x
Transform:
Code to modify:
<Input />
The text was updated successfully, but these errors were encountered: