Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buildElement options should be optional #1375

Merged
merged 1 commit into from
Feb 10, 2022
Merged

fix: buildElement options should be optional #1375

merged 1 commit into from
Feb 10, 2022

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jan 20, 2022 •
edited
Loading

@NullVoxPopuli
Copy link
Contributor

@chancancode thoughts? <3

@locks locks requested review from wycats and chadhietala February 9, 2022 01:26
@locks
Copy link
Contributor

locks commented Feb 9, 2022

Merging on Friday unless someone raises concerns.

@locks locks merged commit 4e31871 into glimmerjs:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

@rwjblue rwjblue rwjblue approved these changes

@wycats wycats Awaiting requested review from wycats

@chadhietala chadhietala Awaiting requested review from chadhietala

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@runspired @NullVoxPopuli @locks @rwjblue @chancancode