failing test for #207 #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
rwjblue
reviewed
Feb 11, 2020
tests/parse-result-test.js
Outdated
| @@ -1211,7 +1221,7 @@ QUnit.module('ember-template-recast', function() { | |||
|
|
|||
| QUnit.test('mutations retain custom whitespace formatting', function(assert) { | |||
| let template = stripIndent` | |||
| <Foo | |||
There was a problem hiding this comment.
Please revert this change, this whitespace is intentional
| @@ -22,6 +22,16 @@ QUnit.module('ember-template-recast', function() { | |||
| assert.equal(print(ast), `<img src="{{this.something}}">`); | |||
| }); | |||
|
|
|||
| QUnit.test('test descriptions with carets pass', function(assert) { | |||
| let template = `it('<' function() { | |||
There was a problem hiding this comment.
I don't really understand what this is testing. This project does not support parsing javascript files...
There was a problem hiding this comment.
@rwjblue I created a test here as it was the simplest way to demonstrate the error I saw while running the angle brackets codemod on integration tests in my app. It looks like someone has posted an issue too: ember-codemods/ember-angle-brackets-codemod#240
There was a problem hiding this comment.
#207 has my initial breakdown if that helps
ghost
mentioned this pull request
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.