-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow @ember/test-helpers
v4 as peerDependency
#9525
Conversation
f249a80
to
26e63be
Compare
@runspired can we get a review also for this one? |
1be0954
to
ddc257b
Compare
@runspired I don't really understand why tests are failing on master. Preston mentioned it might pick up wrong version of test helpers. |
The reason why it was still using v3.x of test-helper is, that there is a override in I have now created a new patch for test-helper v4 and updated on all points to v4. After this change, we were running into Preston has told me, that its possible fixed with updating all |
ember-cli-fastboot-testing has added now peerDependency of |
Opened a PR in ember-provide-consume-context for test-helpers v4... While we wait for patch, i have added under This helps us may be to get green ci |
@mkszepp thank you for working on that ! ❤️ |
ember-provide-consume-context supports now also v4.0.0 of For @Baltazore @runspired can we get a review and release with this changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall seems good, little bit of cleanup to do
d01bfc3
to
0016b6d
Compare
0016b6d
to
9433da2
Compare
Co-Authored-By: Markus Sanin <[email protected]>
9433da2
to
b85888c
Compare
This PR allows consumer apps also
@ember/test-helpers
v4 version (test-helper is now a v2 addon)