Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ember/test-helpers v4 as peerDependency #9525

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Aug 27, 2024

This PR allows consumer apps also @ember/test-helpers v4 version (test-helper is now a v2 addon)

@mkszepp
Copy link
Contributor Author

mkszepp commented Sep 1, 2024

@runspired can we get a review also for this one?

@Baltazore
Copy link
Collaborator

@runspired I don't really understand why tests are failing on master. Preston mentioned it might pick up wrong version of test helpers.

@mkszepp
Copy link
Contributor Author

mkszepp commented Sep 21, 2024

The reason why it was still using v3.x of test-helper is, that there is a override in package.json and a patch for v3... Its not so nice to make a patch for a active addon which is provided from ember team.

I have now created a new patch for test-helper v4 and updated on all points to v4.

After this change, we were running into ember-cli-fastboot-testing error with test-helper, because there is missing the peerDependency (opend a issue embermap/ember-cli-fastboot-testing#872)

Preston has told me, that its possible fixed with updating all @embroider & auto-import versions to latest, but it wasn't... so i have added a patch for now

@mkszepp
Copy link
Contributor Author

mkszepp commented Sep 24, 2024

ember-cli-fastboot-testing has added now peerDependency of @ember/test-helper. Patching ember-cli-fastboot-testing is now not anymore necessary (already changes in this PR)

@mkszepp
Copy link
Contributor Author

mkszepp commented Sep 27, 2024

Opened a PR in ember-provide-consume-context for test-helpers v4...

While we wait for patch, i have added under peerDependencyRules -> allowAny the rule for @ember/test-helpers.

This helps us may be to get green ci

@Baltazore
Copy link
Collaborator

Baltazore commented Sep 27, 2024

@mkszepp thank you for working on that ! ❤️

@mkszepp
Copy link
Contributor Author

mkszepp commented Oct 8, 2024

ember-provide-consume-context supports now also v4.0.0 of test-helpers... now all packages are supporting v3 and v4 of test-helpers

For test-helpers there is now no override anymore necessary. Only the patches are still needed like there were before.

@Baltazore @runspired can we get a review and release with this changes?

Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall seems good, little bit of cleanup to do

@runspired runspired merged commit 5ca1576 into emberjs:main Oct 19, 2024
18 of 20 checks passed
@mkszepp mkszepp deleted the allow-ember-test-helper-v4 branch October 19, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants