Adding better errors when passing null or undefined to modifiers #37
+1,601
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Asserts an error then the function passed to
`did-insert`, `did-update` and `will-destroy`
is not a function.
- Today the error is `fn must be a function`;
`fn` has another meaning in emberland.
mminkoff
reviewed
Aug 2, 2021
This PR fixed an issue that causes and error to be thrown twice for ember versions <= 3.15 glimmerjs/glimmer-vm#1073
I have a PR open to upgrade ember which will allow us to test canary builds
|
@kiwiupover thanks for the PR! Would you mind rebasing to latest master please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts an error then the function passed to
did-insert,did-updateandwill-destroyis not a function.Today the error is
fn must be a functionfnhas another meaning in emberland.Upgrading
ember-resolverfixes the test failures of ember-release, ember-beta, and ember-canary.Canary is failing due to using
Ember.I have an follow up PR that updates ember and ember-cli that will fix this issue.
I have added allow failure for ember-canary due to the failure above.
Here is this same PR running on my github so we can run the tests all the tests are passing except the ember-canary which we know is failing.
kiwiupover#4