-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to addon v2 #66
base: master
Are you sure you want to change the base?
Move to addon v2 #66
Conversation
a862812
to
831662d
Compare
I'm stuck with this PR. Ember embed it's own On the other side, since #54, In classic (non-embroider) build, Embroider, on the other hand, relies on explicit npm dependency and expects Here is a list of things I've tried and do not work at the moment:
|
embroider-build/ember-auto-import#541 might solve the issue |
I confirm this is working. I'm waiting for a new release of |
Read the full issue here emberjs#66 (comment)
@ctjhoa minor, I think we don't need |
"release": "release-it" | ||
}, | ||
"volta": { | ||
"node": "16.14.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctjhoa I think this should stay as 12 as minimum supported version and the same what was used in CI.
Or we could remove engines.node
from @ember/render-modifiers
as it's purely frontend code and has nothing to do with Node.js versions anymore (fully delegated to build pipeline)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed engines.node
226ff16
As this PR introduces a breaking change, go for the latest Node LTS seems fine to me.
@SergeAstapov time for re-review? |
This addon is already in ember-auto-import v2 so it should not be a breaking change.Yes this addon is already ember-auto-import v2 but ember app must be
[email protected]
minimum to fix the@glimmer/validator
issue (cf #66 (comment))This is based on addon v2 with yarn monorepo setup.
It follows