[BUGFIX] Issue #21344 - attributes inconsistently getting removed with falsey values#21345
Draft
NullVoxPopuli wants to merge 2 commits intomainfrom
Draft
[BUGFIX] Issue #21344 - attributes inconsistently getting removed with falsey values#21345NullVoxPopuli wants to merge 2 commits intomainfrom
NullVoxPopuli wants to merge 2 commits intomainfrom
Conversation
Previously, `<input autocomplete={{false}}>` rendered `autocomplete="false"`
because the value reached `DefaultDynamicProperty.set` and was assigned to
the DOM property — for string-valued IDL attributes (autocomplete, name,
popover, draggable, translate, …) the browser then coerced `false` to the
literal string "false" and reflected it back as an attribute. The same
pattern affected `SafeDynamicAttribute`/`SafeDynamicProperty` (href, src)
through `sanitizeAttributeValue`'s `String()` coercion, and
`InputValueDynamicAttribute` set `input.value = "false"`.
Bare `attr={{null}}` and `attr={{undefined}}` already removed the attribute
across every dispatch path — `false` is now treated identically. Concat
form (`attr="{{value}}"`) is intentionally unchanged: it continues to
stringify and renders `"false"`.
The shared sentinel test lives in `isAttrRemoval` so the behavior cannot
drift between dispatch paths again.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…44/falsy-attribute-removal
Treat bare {{false}} as a removal sentinel for HTML attributes
Contributor
📊 Package size report 0.06%↑
🤖 This report was automatically generated by pkg-size-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.