Skip to content

Make the rendering benchmark focus more on rendering #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NullVoxPopuli wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Make the rendering benchmark focus more on rendering #21361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11f1959
Make the rendering benchmark focus more on rendering
NullVoxPopuli May 3, 2026
186668e
Move a bit
NullVoxPopuli May 3, 2026
4ff3a50
Fix benchmark names
NullVoxPopuli May 5, 2026
dd991ce
Cleanup
NullVoxPopuli May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/benchmark/run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ const DEFAULT_MARKERS = [
'clearItems1',
'render1000Items2',
'clearItems2',
'render5000Items1',
'render10000Items1',
'clearManyItems1',
'render5000Items2',
'render10000Items2',
'clearManyItems2',
'render1000Items3',
'append1000Items1',
Expand Down
14 changes: 0 additions & 14 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions smoke-tests/benchmark-app/app/app.js
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions smoke-tests/benchmark-app/app/config/environment.js
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions smoke-tests/benchmark-app/app/router.js
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions smoke-tests/benchmark-app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">

<link rel="stylesheet" href="/bootstrap.min.css">
<link rel="stylesheet" href="/bootstrap.min.css">
<link rel="stylesheet" href="/main.css">
</head>
</head>
<body>
<script type="module">
import { runBenchmark } from './app/run-benchmark.js';
import { runBenchmark } from './src/run-benchmark.js';
import { renderComponent } from '@ember/renderer';

import Application from './app/app';
import environment from './app/config/environment';
import Application from './src/app.gjs';

runBenchmark();
Application.create(environment.APP);
runBenchmark();
renderComponent(Application);
</script>
</body>
</html>
1 change: 0 additions & 1 deletion smoke-tests/benchmark-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"babel-plugin-ember-template-compilation": "^4.0.0",
"decorator-transforms": "^2.3.1",
"ember-source": "workspace:*",
"ember-strict-application-resolver": "^0.1.1",
"vite": "^7.3.0"
},
"engines": {
Expand Down
6 changes: 3 additions & 3 deletions ...nchmark-app/app/templates/application.gjs → smoke-tests/benchmark-app/src/app.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { TheTable } from './the-table.gjs';
import { Jumbotron } from './jumbotron.gjs';
import { TheTable } from './jsfb/the-table.gjs';
import { Jumbotron } from './jsfb/jumbotron.gjs';

<template>
<div id="main">
Expand All @@ -13,4 +13,4 @@ import { Jumbotron } from './jumbotron.gjs';
></span>
</div>
</div>
</template>
</template>
0 ...-tests/benchmark-app/app/services/cell.js → smoke-tests/benchmark-app/src/jsfb/cell.js
View file
Open in desktop
File renamed without changes.
0 ...benchmark-app/app/templates/jumbotron.gjs → ...ests/benchmark-app/src/jsfb/jumbotron.gjs
View file
Open in desktop
File renamed without changes.
7 changes: 3 additions & 4 deletions ...tests/benchmark-app/app/services/state.js → smoke-tests/benchmark-app/src/jsfb/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import Service from '@ember/service';
import { tracked } from '@glimmer/tracking';
import { trackedArray } from '@ember/reactive/collections';

import { run, runLots, add, update, swapRows, deleteRow } from './utils.js';
import { run, runLots, add, update, swapRows } from './utils.js';

export default class State extends Service {
export class State {
data = new trackedArray();
id = 1;
@tracked selected;
Expand Down Expand Up @@ -60,4 +59,4 @@ export default class State extends Service {
isSelected = ({ id }) => {
return this.selected === id;
};
}
}
8 changes: 4 additions & 4 deletions ...benchmark-app/app/templates/the-table.gjs → ...ests/benchmark-app/src/jsfb/the-table.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import Component from '@glimmer/component';
import { fn } from '@ember/helper';
import { service } from '@ember/service';
import { State } from './state.js';

export class TheTable extends Component {
@service state;
state = new State();

/**
* We currently don't have a way to emit HTML with no invisible characters
* and have the template look nice.
* and have the template look nice.
*/
<template>
<table class="table table-hover table-striped test-data">
Expand All @@ -28,4 +28,4 @@ export class TheTable extends Component {
</tbody>
</table>
</template>
}
}
5 changes: 0 additions & 5 deletions ...tests/benchmark-app/app/services/utils.js → smoke-tests/benchmark-app/src/jsfb/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,3 @@ export const swapRows = (data) => {
}
};

export const deleteRow = (data, id) => {
return data.filter((d) => {
return d.id !== id;
});
};
Loading
Loading