Remove RSVP from internal code#21372
Draft
NullVoxPopuli wants to merge 3 commits intomainfrom
Draft
Conversation
Contributor
📊 Size reportTarball size — dist/dev -0.07%↓
dist/prod -0.07%↓
smoke-tests/v2-app-hello-world-template/dist -0.1%↓
🤖 This report was automatically generated by wyvox/pkg-size |
Better types Better types
fe49718 to
f6b185e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to use RSVP, so we can ship less bytes for consumers who also don't use it.
Unfortunately, we still need a tiny abstraction, because all these Promises have a timing behavior that I don't want to mess with right now, and that all that stuff is ran during the "async phase" of backburner