show bug with implementation of lte (et al) as keyword

[mansona]

I discussed this with @NullVoxPopuli last week, but the way that we have implemented all the "X as keyword" PRs (where they automatically add an import) means that the named import now pollutes the JS namespace for the whole file.

The example is a bit contrived in this PR but it demos the problem e.g. we expect this smoke test to fail but it doesn't 🙈

Edit: thanks to @kategengler for the hint on how to make this fail when we have the bad behaviour 🎉

[github-actions]

📊 Size report

Tarball size — 1.2 MB → 1.2 MB

dist/dev   0%↑

File	Before (Size / Brotli)	After (Size / Brotli)
Total (Includes all files)	2.1 MB / 477.2 kB	0%↑2.1 MB / 0%↑477.3 kB

---

dist/prod   0%↑

File	Before (Size / Brotli)	After (Size / Brotli)
Total (Includes all files)	1.9 MB / 436.8 kB	0%↑1.9 MB / 0.01%↑436.8 kB

---

smoke-tests/v2-app-hello-world-template/dist   No changes

File	Before (Size / Brotli)	After (Size / Brotli)
Total (Includes all files)	251.6 kB / 68.8 kB	251.6 kB / 68.8 kB

_{🤖 This report was automatically generated by wyvox/pkg-size}

[NullVoxPopuli]

Refs:

• https://github.com/emberjs/babel-plugin-ember-template-compilation/blob/e95b0cd734bd39cff1e60ad18eaebdfafeee3a2c/src/js-utils.ts#L121
• https://github.com/ef4/babel-import-util/blob/116eda71c62f6a54f2bd3c2f8d4f3daa376766ad/src/index.ts#L62
  • https://github.com/ef4/babel-import-util/blob/116eda71c62f6a54f2bd3c2f8d4f3daa376766ad/src/index.ts#L311
• https://github.com/ef4/babel-import-util/blob/116eda71c62f6a54f2bd3c2f8d4f3daa376766ad/src/index.ts#L87
• https://github.com/ef4/babel-import-util/blob/116eda71c62f6a54f2bd3c2f8d4f3daa376766ad/src/index.ts#L115
• https://github.com/ef4/babel-import-util/blob/116eda71c62f6a54f2bd3c2f8d4f3daa376766ad/src/index.ts#L227
• https://github.com/ef4/babel-import-util/blob/116eda71c62f6a54f2bd3c2f8d4f3daa376766ad/src/index.ts#L229

[NullVoxPopuli]

turns out "name" isn't a thing

[mansona]

I requested a review from someone else in framework since I made the test and you did the fix @NullVoxPopuli 😂

[NullVoxPopuli]

cahoots!

[kategengler]

Should we have a more general test for this for all keywords too?

[NullVoxPopuli]

they all use the same codepath (what was changed), so testing more keywords would be redundant