Skip to content

Add test suite for tree-shakability #21378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullVoxPopuli merged 2 commits into from
May 8, 2026
Merged

Add test suite for tree-shakability #21378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c950dca
Add lint for checking tree-shaking status
NullVoxPopuli May 6, 2026
09953eb
Upstreamed cleaned up a file
NullVoxPopuli May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,9 @@ jobs:
env:
SHOULD_TRANSPILE_FOR_NODE: true
run: pnpm build
- name: test
run: pnpm test:node && pnpm --filter "@handlebars/parser" test
- run: pnpm test:node
- run: pnpm --filter "@handlebars/parser" test
- run: pnpm test:node:vitest

blueprint-test:
name: Blueprint Tests
Expand Down
2 changes: 2 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ export default [
'**/babel.test.config.mjs',
'node-tests/**/*.js',
'tests/node/**/*.js',
'tests/node-vitest/**/*.js',
'smoke-tests/node-template/**/*.js',
'blueprints/**/*.js',
'bin/**/*.js',
Expand Down Expand Up @@ -264,6 +265,7 @@ export default [
'**/babel.test.config.mjs',
'node-tests/**/*.js',
'tests/node/**/*.js',
'tests/node-vitest/**/*.js',
'smoke-tests/node-template/**/*.js',
'blueprints/**/*.js',
'bin/**/*.js',
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"test": "testem ci -f testem.js --host 127.0.0.1 --port 13141",
"test:blueprints": "mocha node-tests/blueprints/**/*-test.js",
"test:node": "qunit tests/node/**/*-test.js",
"test:node:vitest": "pnpm --filter ember-test-node-vitest test:node",
"test:browserstack": "node bin/run-browserstack-tests.js",
"test:wip": "vite build --mode development --minify false && testem ci",
"type-check:internals": "tsc --noEmit",
Expand Down Expand Up @@ -157,7 +158,8 @@
"esbuild"
],
"patchedDependencies": {
"@tracerbench/core@8.0.1": "patches/@tracerbench__core@8.0.1.patch"
"@tracerbench/core@8.0.1": "patches/@tracerbench__core@8.0.1.patch",
"agadoo": "patches/agadoo.patch"
}
},
"peerDependencies": {
Expand Down
22 changes: 22 additions & 0 deletions patches/agadoo.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/index.js b/index.js
index 53354a5de59bb26283bb2cedb6ff5ff0ca6a1fa1..28777e32a9960785fcc31d79ade2a14b200f0cfe 100644
--- a/index.js
+++ b/index.js
@@ -25,7 +25,7 @@ export async function check(input) {
const { code } = result.output[0];

const ast = acorn.parse(code, {
- ecmaVersion: 11,
+ ecmaVersion: 'latest',
sourceType: 'module'
});

@@ -33,7 +33,7 @@ export async function check(input) {
return node.type !== 'ImportDeclaration';
});

- console.log(code);
+// console.log removed by patch

return {
shaken: nodes.length === 0
Loading
Loading