Fix inline if/unless with component args as condition#21380
Draft
Fix inline if/unless with component args as condition#21380
Conversation
Agent-Logs-Url: https://github.com/emberjs/ember.js/sessions/eeaec1fb-7e92-497a-9eae-adcc5fbc23b9 Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inline if helper not working with argument condition
Add regression tests for inline if/unless with component arg as condition
May 7, 2026
Contributor
📊 Size reportTarball size — dist/dev No changes
dist/prod No changes
smoke-tests/v2-app-hello-world-template/dist No changes
🤖 This report was automatically generated by wyvox/pkg-size |
Contributor
|
@copilot use strict mode. Follow the example in the issue report more closely. Don't forget linting |
…omponent branch Agent-Logs-Url: https://github.com/emberjs/ember.js/sessions/c9384514-8a79-4fd1-997c-859207137897 Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Contributor
Author
Done in commit 13ad9c6. The tests now use strict mode with The fix is in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add regression tests for inline if/unless with component arg as condition
Fix inline if/unless with component args as condition
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{if @isOk Ok Ko}}in a child component's template (whereOkandKoare components) fails to reactively update when@isOkchanges — while the block form{{#if @isOk}}updates correctly.Root Cause
In
StdAppend,VM_CONTENT_TYPE_OPinstalls anAssertFilterthat only monitors content type changes (component vs string etc.). When@isOkflips, bothOkandKoare components so the type never changes —AssertFilternever firesvm.throw()and no re-render occurs.Changes
Bug fix in
packages/@glimmer/opcode-compiler/lib/opcode-builder/helpers/stdlib.ts: addedVM_ASSERT_SAME_OPto the dynamic Component branch ofStdAppend. This installs anAssertupdating opcode that monitors the specific reference value. When the value changes from one component to another,Assertfiresvm.throw()to trigger a re-render.Regression tests in
updating-test.tsusing strict mode (defineComponent+trackedObj), following the issue report pattern:Tests cover
ifandunlesswith component values, and a@trackedclass property driving the condition through a parent component.