Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intra page links #165

Closed

Conversation

shankarsridhar
Copy link

@kategengler
Addresses #148

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         106      106           
  Lines         818      818           
=======================================
  Hits          644      644           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92a5b1...ebfb843. Read the comment docs.

@shankarsridhar
Copy link
Author

shankarsridhar commented Jul 2, 2019

@kategengler
I added links which obviously creates a visual diff. And percy test is complaining about it.
Is there a way to make percy happy regarding this?

@kategengler
Copy link
Member

@shankarsridhar Sorry, it is a manual approval step just for that purpose -- to see & approve visual changes.

@kategengler
Copy link
Member

@shankarsridhar This looks great, thanks! When we pulled it down to try, we found that opening a new link (for example: /addons/ember-try#categories) does not link to this section.

It's possible this html feature isn't compatible with Ember (I've never tried to do it in an Ember app before!)

@shankarsridhar
Copy link
Author

ah I see. Yeah, you are right. bummer. it works only when the links are clicked after the page is loaded. But, opening the intra page link in a new tab does not work; and it seems like it is a problem with ember apps.

I am open to suggestions; meanwhile, I'll take a look at https://github.com/mike-north/ember-anchor and see if that would help with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants