imapserver: allow empty lines / commands without breaking connection #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Oct 9, 2025
| return nil | ||
| } | ||
|
|
||
| if dec.ExpectCRLF() { |
There was a problem hiding this comment.
The Expect family of functions sets the error field in the decoder. Since not getting a CRLF is valid, we should use Decoder.CRLF instead.
| } | ||
|
|
||
| func (c *Conn) readCommand(dec *imapwire.Decoder) error { | ||
| for { |
There was a problem hiding this comment.
I don't think using a for loop is necessary, plus it won't behave well regarding the command read timeout. We can just return if we got a CRLF and leave it to the caller to invoke readCommand again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently imapserver will end connection if empty command is given (CR)