schedule/feeds: make json feed schema compatible #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kunsi
force-pushed
the
kunsi-schedule-json-schema-compatible
branch
from
aef04d9
to
d94e2f3
Compare
Kunsi
force-pushed
the
kunsi-schedule-json-schema-compatible
branch
from
d94e2f3
to
d70ab38
Compare
Kunsi
commented
May 24, 2024
apps/schedule/feeds.py
Outdated
| @@ -46,12 +49,146 @@ def schedule_json(year): | |||
| return Response(json.dumps(schedule), mimetype="application/json") | |||
|
|
|||
|
|
|||
| @schedule.route("/schedule/schedule-<int:year>.json") # TODO validate url with upstream | |||
There was a problem hiding this comment.
Maybe we can just use /schedule/<int:year>.json and merge this pull request after this years EMF?
also add request argument to show the old-style json schedule
Kunsi
commented
Jun 12, 2024
| abort(404) | ||
|
|
||
| schedule = [_convert_time_to_str(p) for p in _get_scheduled_proposals(request.args)] | ||
| if request.args.get('format') == 'array': |
There was a problem hiding this comment.
Also feels wrong to do it like this. I don't know. Feedback please! (I'm happy to expose the schema-compatible json on another endpoint, i just have no clue what would be a good name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.