Improve async compatibility of app store #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves some code from the background task to the main task, and refactors it to allow use of async methods. This looks like these tasks were in background from the idea that the background task runs 'in the background', rather than runs 'when the app is in the background'. There are two calls that use requests.get, which block the update task. By refactoring slightly to use async, we can use async_helpers.unblock to move them to a thread.
npentrel
reviewed
Jun 26, 2024
| get, render_update, APP_STORE_LISTING_URL | ||
| ) | ||
| except Exception: | ||
| self.update_state("no_index") |
There was a problem hiding this comment.
This would get changed in the next line wouldn't it
Comment on lines
+259
to
+265
| try: | ||
| self.response = await async_helpers.unblock( | ||
| get, render_update, APP_STORE_LISTING_URL | ||
| ) | ||
| except Exception: | ||
| self.update_state("no_index") | ||
| self.update_state("index_received") |
There was a problem hiding this comment.
Yes, per Naomi's comment I think this ought to be like this?
Suggested change
| try: | |
| self.response = await async_helpers.unblock( | |
| get, render_update, APP_STORE_LISTING_URL | |
| ) | |
| except Exception: | |
| self.update_state("no_index") | |
| self.update_state("index_received") | |
| try: | |
| self.response = await async_helpers.unblock( | |
| get, render_update, APP_STORE_LISTING_URL | |
| ) | |
| self.update_state("index_received") | |
| except Exception: | |
| self.update_state("no_index") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some code from the background task to the main task, and refactors it to allow use of async methods. This looks like these tasks were in background from the idea that the background task runs 'in the background', rather than runs 'when the app is in the background'.
There are two calls that use requests.get, which block the update task. By refactoring slightly to use async, we can use async_helpers.unblock to move them to a thread.