Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ctx with fixed alpha channel #38

Merged
merged 1 commit into from
May 28, 2024

Conversation

npentrel
Copy link
Contributor

@npentrel npentrel commented May 20, 2024

I fixed the rgba method to have values from 0-1.0 for alpha channel (as I think is customary) in the ctx library and added the error handling that there was a todo for.

@MatthewWilkes
Copy link
Member

This looks good, but I'm not convinced that the comment here is correct, trying on an actual badge I'm having trouble getting correct behaviour for the 0..256 range for r,g,b

@npentrel
Copy link
Contributor Author

I have only tested with the simulator where this does seem to work for me. What behaviour are you seeing?

@MatthewWilkes
Copy link
Member

I meant the todo in the simulator code. It talks about automatically dispatching depending on the 0..255 or 0..1 ranges, if I'm understanding correctly. However, on the physical badge I was seeing only the 0..1 range working right. Let me check this again.

@npentrel
Copy link
Contributor Author

Is that in _sim.py? I only see a TODO there about LEDs which is unrelated I think

@MatthewWilkes
Copy link
Member

I'd meant the todo you referenced, but I double checked and it's working fine. I'm not sure what had confused me before, sorry for the delay merging.

@MatthewWilkes MatthewWilkes merged commit 7d74863 into emfcamp:main May 28, 2024
1 check passed
@npentrel npentrel deleted the fix-rgba branch June 2, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants