macOS: Add movable_by_window_background option to viewport
#5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmerlin
requested changes
Nov 30, 2024
crates/egui/src/viewport.rs
Outdated
Comment on lines
436
to
437
| /// macOS: Set to `true` to allow the window to be moved by dragging the background. | ||
| #[inline] |
There was a problem hiding this comment.
Bildschirmaufnahme.2024-11-30.um.12.36.56.mov
It doesn't really work well with sliders and draggable widgets, but I guess that's expected.
But maybe add a note to the comment that it doesn't, otherwise people might expect that to work and open issues about it.
|
Sorry for taking so long, I added your requested warning to the doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option called
movable_by_window_backgroundalongside a new builder method. When set to true, the window is movable by dragging its background (Apple Docs)This is exclusive to macOS systems, similar to
fullsize_content_view.