Make the toast content grow to fill remaining space #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the content div only takes up as much space as is needed for the title/description of the toast. This caused a problem for me when I rendered a progress bar in the toast description. By default, the progress bar was only as wide as the title, so it looked a bit funny. This PR fixes that by making the content grow to fill available space, so that variable-width items like progress bars take up the full content area by default.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I wonder if this will resolve the issue I'm facing here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the content div only takes up as much space as is needed for the title/description of the toast.
This caused a problem for me when I rendered a progress bar in the toast description. By default, the progress bar was only as wide as the title, so it looked a bit funny. This PR fixes that by making the content grow to fill available space, so that variable-width items like progress bars take up the full content area by default.