Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue π±:
Closes -
What has been done β :
Hello, i was trying to recreate Sonner by myself and found out some unnecessary code in useEffect timer:
What unnecessary code this useEffect have?:
let remainingTime = duration
and recalculate logic for remainingTime because we don't save remainingTime between rerenders. In this case we can just useduration
prop for setTimeout nothing will change.let timeoutId: NodeJS.Timeout;
,closeTimerStartTimeRef
andlastCloseTimerStartTimeRef
we can contain this in timerRef.What did i do?:
recalculateRemainingTime = false
.lastCloseTimerStartTimeRef
andcloseTimerStartTimeRef
create just one:recalculateRemainingTime
prop for right delay before trigger:Screenshots/Videos π₯:
N/A