fix: prevent double custom toast counter increase when initial id is undefined #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When creating a custom wrapper around Sonner
customtoast i have encountered an issue with toast updating.Despite providing proper id to the second invocation, second toast was created, instead of an update to the existing one.
After skimming trough the code, i have noticed that the generated
idwas overwritten in case ofid: undefined.In that case
toastsCounterwas increased again insidecreate, despite originally created id being returned from the function, creating id mismatch.Fix:
Changed the parameter order when calling
createfromcustom, so generated id would not be overwritten bydata.idbeing set toundefined.Also added regression test.