Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark mode for close button #531

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hunterrmartinn
Copy link
Contributor

@hunterrmartinn hunterrmartinn commented Dec 22, 2024

🎫 Issue:

Closes #412
Closes #320

⚫ Proposed Fix:

To keep consistent styling I tried matching the same hover behavior from light mode.

close-button-dark-mode.mp4
Screenshot 2024-12-22 at 2 36 55 PM

Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 5:57pm

@hunterrmartinn
Copy link
Contributor Author

🔴 @emilkowalskirun: npx playwright install --with-deps is failing

@hunterrmartinn hunterrmartinn changed the title Dark mode for close button fix: dark mode for close button Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close button dark mode BUG: Darkmode doesn't propagate to closeButton
1 participant