ci: simplify and update

emma-heriot-watt · Dec 1, 2023 · 798c694 · 798c694
1 parent 8edfadf
commit 798c694
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 94 deletions.
diff --git a/.github/workflows/continuous_integration.yml b/.github/workflows/continuous_integration.yml
@@ -41,55 +41,33 @@ jobs:
     if: ${{needs.changes.outputs.python == 'true' && !github.event.pull_request.draft }}
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v3
+      - name: Checkout the repository
+        uses: actions/checkout@v4
 
       - name: Setup reviewdog
         uses: reviewdog/action-setup@v1
 
+      - name: Install Poetry
+        run: pipx install poetry
+
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
-
-      - name: Configure GitHub to download private repos
-        env:
-          PAT: ${{ secrets.PAT }}
-        run: |
-          git config --global url."https://${PAT}@github.com/".insteadOf "https://github.com/"
-
-      - name: Install Poetry
-        uses: snok/install-poetry@v1
-
-      - name: Install PoethePoet
-        run: poetry self add 'poethepoet[poetry_plugin]'
-
-      - name: Load cached Python
-        uses: tespkg/actions-cache@v1
-        id: python-cache
-        with:
-          path: ~/.cache/pypoetry/virtualenvs
-          key: ${{ runner.os }}-poetry-${{ hashFiles('poetry.lock') }}-${{ hashFiles('pyproject.toml') }}
-          bucket: ${{ secrets.AWS_S3_BUCKET_NAME }}
-          accessKey: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          secretKey: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          cache: "poetry"
 
       - name: Install dependencies
-        run: |
-          poetry install
+        run: poetry install
 
       - name: Load mypy cache
-        uses: tespkg/actions-cache@v1
+        uses: actions/cache@v3
         id: mypy-cache
         with:
           path: .mypy_cache
           key: ${{ runner.os }}-mypy-cache-${{ hashFiles('poetry.lock') }}-${{hashFiles('pyproject.toml') }}
           restore-keys: |
             ${{ runner.os }}-mypy-cache-${{ hashFiles('poetry.lock') }}-${{hashFiles('pyproject.toml') }}
             ${{ runner.os }}-mypy-cache-
-          bucket: ${{ secrets.AWS_S3_BUCKET_NAME }}
-          accessKey: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          secretKey: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
 
       - name: Run mypy with reviewdog
         env:
@@ -118,41 +96,22 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup reviewdog
         uses: reviewdog/action-setup@v1
 
+      - name: Install Poetry
+        run: pipx install poetry
+
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
-
-      - name: Configure GitHub to download private repos
-        env:
-          PAT: ${{ secrets.PAT }}
-        run: |
-          git config --global url."https://${PAT}@github.com/".insteadOf "https://github.com/"
-
-      - name: Install Poetry
-        uses: snok/install-poetry@v1
-
-      - name: Install PoethePoet
-        run: poetry self add 'poethepoet[poetry_plugin]'
-
-      - name: Load cached Python
-        uses: tespkg/actions-cache@v1
-        id: python-cache
-        with:
-          path: ~/.cache/pypoetry/virtualenvs
-          key: ${{ runner.os }}-poetry-${{ hashFiles('poetry.lock') }}-${{ hashFiles('pyproject.toml') }}
-          bucket: ${{ secrets.AWS_S3_BUCKET_NAME }}
-          accessKey: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          secretKey: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          cache: "poetry"
 
       - name: Install dependencies
-        run: |
-          poetry install
+        run: poetry install
 
       - name: Run flake8
         env:
@@ -178,39 +137,33 @@ jobs:
     if: ${{ !github.event.pull_request.draft }}
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
-
-      - name: Configure GitHub to download private repos
-        env:
-          PAT: ${{ secrets.PAT }}
-        run: |
-          git config --global url."https://${PAT}@github.com/".insteadOf "https://github.com/"
+          cache: "pip"
 
       - name: Install pre-commit
         run: |
           pip install pre-commit
+
       - name: Load cached pre-commit environment
-        uses: tespkg/actions-cache@v1
+        uses: actions/cache@v3
         id: pre-commit-cache
         with:
           path: ~/.cache/pre-commit
           key: ${{ runner.os }}-pre-commit-${{ hashFiles('**/.pre-commit-config.yaml') }}
           restore-keys: |
             ${{ runner.os }}-pre-commit-
-          bucket: ${{ secrets.AWS_S3_BUCKET_NAME }}
-          accessKey: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          secretKey: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
 
       - name: Run pre-commit hook
         id: run-pre-commit-hooks
         run: |
           git add .pre-commit-config.yaml
           pre-commit run --color=always --all-files
+
       - name: Annotate any changes using reviewdog
         if: ${{ failure() }}
         id: reviewdog-suggester

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -5,8 +5,10 @@ on:
   workflow_call:
   pull_request:
     branches: [main]
+    paths-ignore: ["**/*.md", "**/*.rst"]
   push:
     branches: [main]
+    paths-ignore: ["**/*.md", "**/*.rst"]
 
 env:
   PYTHON_VERSION: 3.9
@@ -37,7 +39,6 @@ jobs:
               - 'pyproject.toml'
               - 'poetry.lock'
               - '.github/workflows/tests.yml'
-              - 'src/emma_experience_hub/**/*'
 
   python:
     name: Run Python test suite
@@ -50,42 +51,22 @@ jobs:
     if: ${{needs.changes.outputs.python == 'true' && !github.event.pull_request.draft }}
     steps:
       - name: Checkout the repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+
+      - name: Install Poetry
+        run: pipx install poetry
 
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
-
-      - name: Install Poetry
-        uses: snok/install-poetry@v1
-
-      - name: Install PoethePoet
-        run: poetry self add 'poethepoet[poetry_plugin]'
-
-      - name: Configure GitHub to download private repos
-        env:
-          PAT: ${{ secrets.PAT }}
-        run: |
-          git config --global url."https://${PAT}@github.com/".insteadOf "https://github.com/"
-
-      - name: Load cached Python
-        uses: tespkg/actions-cache@v1
-        id: python-cache
-        with:
-          path: ~/.cache/pypoetry/virtualenvs
-          key: ${{ runner.os }}-poetry-${{ hashFiles('poetry.lock') }}-${{ hashFiles('pyproject.toml') }}
-          bucket: ${{ secrets.AWS_S3_BUCKET_NAME }}
-          accessKey: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          secretKey: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          cache: "poetry"
 
       - name: Install dependencies
-        run: |
-          poetry install
+        run: poetry install
 
       - name: Run test suite
-        run: |
-          poetry run poe test-everything | tee pytest-coverage.txt
+        run: poetry run poe test-everything | tee pytest-coverage.txt
 
       - name: Comment the coverage
         if: ${{ always() && github.event_name == 'pull_request' && github.actor != 'dependabot[bot]' }}