Skip to content

Add maximumDuration #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmitry-shechtman wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add maximumDuration #14

dmitry-shechtman wants to merge 2 commits into from

Conversation

@dmitry-shechtman
Copy link

@dmitry-shechtman dmitry-shechtman commented May 8, 2017

Closes #10.

Lakritzator
Lakritzator approved these changes May 15, 2017
View reviewed changes
Copy link

@Lakritzator Lakritzator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. But isn't this just "duration" or a "timeout" instead of maximum duration?

@dmitry-shechtman
Copy link
Author

dmitry-shechtman commented May 15, 2017

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Lakritzator Lakritzator Lakritzator approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitry-shechtman @Lakritzator