Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email: Data table in email missing row headers <th scope="row"> for the cells in column 1. #614

Open
8 tasks done
JohnHewittCriterion opened this issue Mar 15, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@JohnHewittCriterion
Copy link

JohnHewittCriterion commented Mar 15, 2018

Notes

The order details data table is missing row headers for column 1 cells. This is essential for screen readers to have context when navigating a table.

Example:
http://pauljadam.com/demos/data-tables.html

image.png

Linkage: CTF-97
WCAG: 1.3.1 Info and Relationship

Acceptance criteria

  • table header present for screen reader (will)

Tasks

Definition of Done

  • Code unit / e2e tested and comply with QWASP
  • No new security vulnerabilities
  • Internal team code review
  • Documentation / readme.md / CircleCI updated
  • Docker updated
  • Compare finished design with mockup
  • Usability tested
@sadlerw sadlerw self-assigned this Mar 21, 2018
@sadlerw sadlerw added this to the Sprint 12 milestone Mar 21, 2018
@sadlerw
Copy link

sadlerw commented Mar 22, 2018

@JohnHewittCriterion so I can add the th, but I think the real fix here is the screen reader wants the table to be role="presentation" which I added.

I'd like to hide from the user though, so:

screen shot 2018-03-22 at 11 40 22 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants