[test] Use all_engines more consistently. NFC
#25112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
all_engines more consistentlyall_engines more consistently. NFC
sbc100
commented
Aug 29, 2025
test/test_other.py
Outdated
|
|
||
| for engine in config.JS_ENGINES: | ||
| if engine == config.V8_ENGINE: | ||
| print('skipping v8 due to https://github.com/emscripten-core/emscripten/issues/25010') |
There was a problem hiding this comment.
This is has been fixed.
sbc100
force-pushed
the
js_engines
branch
4 times, most recently
from
2b5f0b7 to
e167568
Compare
This allows us remove some the nested loops from these tests. Ideally `all_engines` would generate separate tests for each engine but that can be a followup change.
|
I have a great followup that actually splits these into one-test-per-engine |
|
Here is my followup which I'm pretty happy with: #25115 |
kripken
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us remove some the nested loops from these tests.
Ideally
all_engineswould generate separate tests for each engine but that can be a followup change.