[testing] Use threads for the http servers. #25141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 2, 2025
test/common.py
Outdated
|
|
||
| class ServerThread(threading.Thread): | ||
| """A generic thread class to create and run a server.""" | ||
| def __init__(self, server_creator, *server_args): |
There was a problem hiding this comment.
server_ctor or server_constructor.. or maybe server_class?
There was a problem hiding this comment.
It takes a function, so I don't think those names work.
Workers in the pool are already daemon processes and do not allow you to create sub processes. More on the daemonic stuff: https://docs.python.org/3/library/multiprocessing.html#multiprocessing.Process.daemon |
This is in preparation for the parallel browser tests where sub processes aren't allowed. The server no longer changes the directory during tests, since we can now rely on the test runner changing the directory (same process).
brendandahl
force-pushed
the
threaded-server
branch
from
724a71c to
a34bc70
Compare
sbc100
reviewed
Sep 3, 2025
test/common.py
Outdated
|
|
||
| cls.harness_in_queue = queue.Queue() | ||
| cls.harness_out_queue = queue.Queue() | ||
| cls.harness_server = HttpServerThread(harness_server_func, cls.harness_in_queue, cls.harness_out_queue, cls.PORT) |
There was a problem hiding this comment.
Can we at least rename harness_server_func to something like make_test_server or make_test_harness since that function now returns that server rather than running it?
kripken
approved these changes
Sep 3, 2025
juj
added a commit
that referenced
this pull request
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the parallel browser tests where sub processes aren't allowed.
The server no longer changes the directory during tests, since we can now rely on the test runner changing the directory (same process).