Skip to content

Update test code after #20067 was fixed. NFC #25156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

Update test code after #20067 was fixed. NFC #25156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9655,7 +9655,6 @@ def test_abort_on_exceptions_main(self):
self.assertNotContained('Aborted', output)

@node_pthreads
@flaky('https://github.com/emscripten-core/emscripten/issues/20067')
@no_esm_integration('ABORT_ON_WASM_EXCEPTIONS is not compatible with WASM_ESM_INTEGRATION')
def test_abort_on_exceptions_pthreads(self):
self.set_setting('ABORT_ON_WASM_EXCEPTIONS')
Expand All @@ -9668,7 +9667,6 @@ def test_abort_on_exceptions_pthreads(self):
@no_esm_integration('ABORT_ON_WASM_EXCEPTIONS is not compatible with WASM_ESM_INTEGRATION')
@is_slow_test
def test_stress_proxy_to_pthread_hello_world(self):
self.skipTest('https://github.com/emscripten-core/emscripten/issues/20067')
self.set_setting('ABORT_ON_WASM_EXCEPTIONS')
self.set_setting('PROXY_TO_PTHREAD')
self.set_setting('EXIT_RUNTIME')
Expand Down