Remove shell=True from rebaseline_tests.py. NFC
#25158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
rebaseline_tests
branch
from
84fb88e to
79971fe
Compare
sbc100
changed the title
shell=True from rebaseline_tests.py. NFCshell=True from rebaseline_tests.py. NFC
juj
approved these changes
Sep 3, 2025
sbc100
force-pushed
the
rebaseline_tests
branch
from
79971fe to
2423c7e
Compare
kripken
approved these changes
Sep 3, 2025
This was added in emscripten-core#25142 to fix windows but inadvertently broke linux. Turns out the `shell=True` means that first argument should be a single string, and not and array of arguments. For some reason using an array along with `shell=True` was causing `subprocess.check_call` to silently do nothing.
sbc100
force-pushed
the
rebaseline_tests
branch
from
2423c7e to
4483fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #25142 to fix windows but inadvertently broke linux.
Turns out the
shell=Truemeans that first argument should be a single string, and not and array of arguments. For some reason using an array along withshell=Truewas causingsubprocess.check_callto runtest/runneronly without any aguments.