Replace globalThis polyfill in exportWasmSymbols. NFC #25172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
exportWasmSymbols
branch
2 times, most recently
from
3e6a7c1 to
8f4370c
Compare
juj
reviewed
Sep 4, 2025
juj
reviewed
Sep 4, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 4, 2025
This will allow us to use it from other places. Split out from emscripten-core#25172
|
I split out the moving of the function so it can be separated from the usage with |
sbc100
added a commit
that referenced
this pull request
Sep 4, 2025
This will allow us to use it from other places. Split out from #25172
sbc100
force-pushed
the
exportWasmSymbols
branch
from
8f4370c to
1d6e0d0
Compare
sbc100
force-pushed
the
exportWasmSymbols
branch
from
1d6e0d0 to
60b875a
Compare
|
OK, so I was wrong about the strict JS mode. Because I added a new test anyway just to confirm. I think its still probably work landing this, if only to remove the duplication here. |
sbc100
commented
Sep 8, 2025
There was a problem hiding this comment.
OK, to land this?
The emGlobalThis should be going away real soon, and only exists for users using -sLEGACY_BROWSER_SUPPORT so most users won't be effected.
But converting this codepath to use emGlobalThis it means it will automatically get cleaned up when emGlobalThis goes away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This polyfill is code a duplicate of the
emGlobalThispolyfill.