Mark LEGACY_VM_SUPPORT as incompatible with MEMORY64 #25183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
legacy_vm_wasm64
branch
from
4f9e7a5 to
7f063ff
Compare
Even `-sMEMORY64=2` is not supported because out lowering pass doesn't yet support it: ``` Running test_core: (1 tests) test_embind_val_basics_legacy (test_core.wasm64l.test_embind_val_basics_legacy) ... Fatal: Memory64 and multi-memory not supported by memory.copy lowering em++: error: '/usr/local/google/home/sbc/dev/wasm/binaryen-out/bin/wasm-opt --signext-lowering --llvm-nontrapping-fptoint-lowering --llvm-memory-copy-fill-lowering --memory64-lowering --table64-lowering test_embind_val_basics.wasm -o test_embind_val_basics.wasm -g --mvp-features --enable-bulk-memory --enable-bulk-memory-opt --enable-call-indirect-overlong --enable-memory64 --enable-multivalue --enable-mutable-globals --enable-nontrapping-float-to-int --enable-reference-types --enable-sign-ext' failed (returned 1) None ``` Fixes: emscripten-core#25182
sbc100
force-pushed
the
legacy_vm_wasm64
branch
from
7f063ff to
96f590d
Compare
juj
approved these changes
Sep 4, 2025
kripken
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even
-sMEMORY64=2is not supported because out lowering pass doesn't yet support it:Fixes: #25182