Remove a bunch of redundant code from parallel_testsuite.py #25739
+39
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
parallel_testsuite
branch
from
fa7a845 to
5a0874f
Compare
sbc100
force-pushed
the
parallel_testsuite
branch
8 times, most recently
from
9406ef0 to
e5db51f
Compare
Collaborator
Author
|
PTAL, I think this is a really nice cleanup of unnecessary code. |
juj
reviewed
Nov 8, 2025
juj
reviewed
Nov 8, 2025
juj
reviewed
Nov 8, 2025
juj
reviewed
Nov 8, 2025
juj
reviewed
Nov 8, 2025
juj
approved these changes
Nov 8, 2025
Collaborator
juj
left a comment
juj
left a comment
There was a problem hiding this comment.
Nice, looks like a great simplification.
sbc100
force-pushed
the
parallel_testsuite
branch
from
e5db51f to
0e7df1e
Compare
All this infrastructure with the BufferedTestBase was added to work around that fact that we were previously using using a fake TestResult class so that is could be serialized. However in emscripten-core#25737 I converted to using TestResult as the superclass of BufferedParallelTestResult. There were only two members that needed to me removed to make it work. With that change landed we can now remove a log of the other code here.
sbc100
force-pushed
the
parallel_testsuite
branch
from
0e7df1e to
ec72dca
Compare
juj
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this infrastructure with the BufferedTestBase was added to work around that fact that we were previously using using a fake TestResult class so that is could be serialized.
However in #25737 I converted to using TestResult as the superclass of BufferedParallelTestResult. There were only two members that needed to me removed to make it work. The
TestResultclass stores all exceptions as strings so there is also no need to the Fake exceptions stuff anymore.