Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

139/fav button fix #141

Merged
merged 2 commits into from
Nov 15, 2024
Merged

139/fav button fix #141

merged 2 commits into from
Nov 15, 2024

Conversation

nichgalzin
Copy link
Contributor

Description

**Closes #139 **
Include here a short description of what behaviour this Pull Request introduces.
Outline any new dependencies introduced.

This pull request includes several changes to the ManageFavouritesButton component and a small CSS adjustment in the PopupInfo component.

Improvements to ManageFavouritesButton component:

  • Added a new state hasUserSession to track if a user session exists. (src/components/popup-components/ManageFavouritesButton/ManageFavouritesButton.tsx)
  • Updated the logic to check for a user session and set the hasUserSession state accordingly. (src/components/popup-components/ManageFavouritesButton/ManageFavouritesButton.tsx)
  • Updated the component rendering to conditionally display the button controls only if a user session exists. (src/components/popup-components/ManageFavouritesButton/ManageFavouritesButton.tsx)

CSS adjustment:

  • Increased the width of buttons in the PopupInfo component from 250px to 275px. (src/components/popup-components/PopupInfo/PopupInfo.css)

UI changes

Screenshot 2024-11-15 at 11 27 30 Screenshot 2024-11-15 at 11 29 35

Copy link
Contributor

@camelPhonso camelPhonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! No real notes 👌

@camelPhonso camelPhonso merged commit c87ffc4 into dev Nov 15, 2024
1 check passed
@camelPhonso camelPhonso deleted the 139/fav-button-fix branch November 15, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favourite button styling issue and log out state
2 participants