chore - 1481 the kernel-side crates move into their rings - #1582
Open
dannymeijer wants to merge 18 commits into
Open
dannymeijer wants to merge 18 commits into
dannymeijer wants to merge 18 commits into
Conversation
…an-ir-and-incan-emit-crates
…n-store-and-oven-rustc-crates
…k-model-into-oven-model
…an-provider-and-incan-oven-facet-crates
…480-oven-store-and-oven-rustc-crates
…/1480-lock-model-into-oven-model
…incan-provider-and-incan-oven-facet-crates
… cycle reaches it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 4a of the layout rewrite: the crates that are not toolchain support crates move into their rings by directory.
incan_syntax,incan_semantics_coreandincan_codegraphgo toloaves/kernel/;rust_inspectandincan_semantics_stdlibgo toloaves/compiler/— the semantics packs are compiler implementation perlayering.md, so they sit besideincan_providerrather than in the kernel;crates/third_partybecomesloaves/third_party. Crate names stay what they are (step 5 renamesincan_core→incan_lang,incan_semantics_core→incan_semantics,rust_inspect→incan_inspect); the directories carry the crate names until then, and each crate's README says so.The five toolchain support crates stay under
crates/for now, deliberately:incan_core,incan_derive,incan_stdlib,incan_vocabandincan_web_macrosare what the release archive ships undercrates/, what generated projects and SDK components depend on by path, and what CI'sINCAN_TOOLCHAIN_CRATES_DIRoverride points at as one directory. They move together with the toolchain path policy in 4b (the stdlib ring), as recorded on #1481.What names the moved paths and follows them: every manifest path dependency (the root, the compiler-ring crates, the kernel crates' own
../incan_core/../incan_vocab); the compiler-suite target spelling forrust_inspect's lib inoven_model::compiler_suite_env; thethird_partyregistry-patch directory policy inlegacy_cargo(and its test); the effect-digest roots for the two semantics crates; the rustdoc gate'sthird_partyskip rule; the semantic-string audit's roots and fixture entries forrust_inspect; the reporter label in one native-test test; and the in-repo docs that name the parser directory (AGENTS.md, the test skill and agent). The moved crates' rustdoc fills the width, like every crate moved before it.Type of change
docs/RFCs/*)Area(s)
Key details
crates/layout is untouched because the support crates did not move.Cargo.lockdoes not change (path dependencies record no paths).check_oven_ringstill passes: no Oven crate depends on any moved crate.scripts/check_doc_paths.py(step 6) catches the docs-site ones.Testing / verification
cargo check -p incanin the six feature configurations;cargo clippy --all-targetsdefault and--all-featureswith-D warnings; rustdoc gate lastcargo test -p incan_syntax -p incan_semantics_core -p incan_codegraph -p rust_inspect -p incan_semantics_stdlib— 543 tests, theincan_syntaxembedded-fragment tests reading theexamples/proconsumers through one more../cargo test --test cli_layering_guardrails --test vocab_guardrails --test layering_guardcargo test --test codegen_snapshot_tests— 266 unchangedmake check-oven-ringcli::commands::inspect,cli::commands::oven,lspmake test-one TEST_ROOT=tests/cli_surface_tests.rs TEST_EXACT=a_cargo_manifest_beside_a_loaf_manifest_warns_without_stopping_the_build— bake + build, the compiler suite's target plan namesrust_inspect's new pathDocs impact
Checklist
Part of #1481 (slice 5, #1478). Builds on #1577–#1581: the branch carries their commits, so the diff shows every step until they land and merge-commit syncs narrow it to this one.