Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support #9230

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Add Python 3.12 support #9230

merged 2 commits into from
Feb 20, 2024

Conversation

math-a3k
Copy link
Contributor

This is a test for the CI of python 3.12 since I can't commit to auvipy:py312 nor make a pull request to that branch (#9157). The tests pass locally, if confirmed on the CI, @auvipy can apply the commit to his branch and then merge. Otherwise, please ignore and close.

@math-a3k
Copy link
Contributor Author

@auvipy: It turns out the changes were already committed to master, didn't see them, rebased and I fixed the blacken error so the CI passes

@cclauss
Copy link
Contributor

cclauss commented Jan 24, 2024

Please rebase

@cclauss
Copy link
Contributor

cclauss commented Jan 24, 2024

py312-django42: OK ✔ in 40.27 seconds 🚀

@cclauss
Copy link
Contributor

cclauss commented Jan 24, 2024

I would say this is ready for review. Py3.12 is supported but Dj5 is not.

@math-a3k
Copy link
Contributor Author

I would say this is ready for review. Py3.12 is supported but Dj5 is not.

Can you elaborate on why not? I think if the test suite passes it in good condition to start receiving bug reports

@cclauss
Copy link
Contributor

cclauss commented Jan 25, 2024

The test results are:

  py312-django42: OK (40.27=setup[15.62]+cmd[24.66] seconds)
  py312-djangomain: IGNORED FAIL code 1 (45.56=setup[20.94]+cmd[24.62] seconds)

And pytest ends with:

=========== 12 failed, 1540 passed, 4 skipped, 4 warnings in 22.60s ============
py312-djangomain: exit 1 (24.62 seconds)

which is why you are still working on #9233.

If you can merge #9233 then Dj5 can be supported. If not, then this PR demonstrates that Py3.12 can be supported w/o Dj5.

@math-a3k
Copy link
Contributor Author

If you can merge #9233 then Dj5 can be supported. If not, then this PR demonstrates that Py3.12 can be supported w/o Dj5.

Indeed, in #9233:

  py312-django42: OK (40.80=setup[15.85]+cmd[24.95] seconds)
  py312-djanggo50: OK (36.33=setup[11.82]+cmd[24.51] seconds)
  py312-djangomain: OK (45.29=setup[21.06]+cmd[24.23] seconds)

and is based on this branch, meant to be reviewed after this

@math-a3k math-a3k marked this pull request as ready for review January 25, 2024 02:00
@math-a3k math-a3k changed the title Python 3.12 support CI test Add Python 3.12 support Jan 25, 2024
@auvipy auvipy merged commit 37ec04d into encode:master Feb 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants