-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 support #9230
Add Python 3.12 support #9230
Conversation
@auvipy: It turns out the changes were already committed to master, didn't see them, rebased and I fixed the blacken error so the CI passes |
Please rebase |
|
I would say this is ready for review. Py3.12 is supported but Dj5 is not. |
Can you elaborate on why not? I think if the test suite passes it in good condition to start receiving bug reports |
The test results are:
And pytest ends with:
which is why you are still working on #9233. If you can merge #9233 then Dj5 can be supported. If not, then this PR demonstrates that Py3.12 can be supported w/o Dj5. |
Indeed, in #9233:
and is based on this branch, meant to be reviewed after this |
This is a test for the CI of python 3.12 since I can't commit to auvipy:py312 nor make a pull request to that branch (#9157). The tests pass locally, if confirmed on the CI, @auvipy can apply the commit to his branch and then merge. Otherwise, please ignore and close.