Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop HTML line breaks on long headers. #9438

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Drop HTML line breaks on long headers. #9438

wants to merge 2 commits into from
+1 −11

Conversation

tomchristie
Copy link
Member

Reverts #777

We don't really need to add line breaks <br> in the browsable API on long headers. They render fine in the browser as-is.
Superseeds fix in #9435 dealing with possible XSS against the browsable API.

@tomchristie tomchristie mentioned this pull request Jun 14, 2024
Merged
auvipy
auvipy approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was some merge conflicts, so I tried to fix them

auvipy
auvipy requested changes Jun 15, 2024
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we need to remove related tests as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchristie @auvipy