Long polling more time to recover #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WalkthroughThe overall change in this pull request involves adjusting the system's response time to server failures. Specifically, it increases the wait time before retrying a failed server request from 3 seconds to 10 seconds, effectively extending the total wait time from 9 seconds to 30 seconds. Changes
NotesChat with
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sergei-encord
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
Long polling more time to recover
With current settings we wait up to
LONG_POLLING_SLEEP_ON_FAILURE_SECONDS * LONG_POLLING_RESPONSE_RETRY_Nseconds for server to respond correctly.With current defaults that is 3 * 3s = 9s in total, which is too small, let's increase this to 3 * 10s = 30s
Summary by CodeRabbit
Chore:
LONG_POLLING_SLEEP_ON_FAILURE_SECONDSfrom 3 to 10 inencord/client.py. This extends the time the system waits for a server response on failure, improving resilience against temporary network issues.