-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic datasets minimal feature #452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (4)
- encord/client.py (2)
- encord/dataset.py (3)
- encord/orm/dataset.py (15)
- encord/user_client.py (2)
Files not reviewed due to errors (1)
- encord/orm/dataset.py (no response)
Review comments generated (8)
- Review: 2
- LGTM: 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (3)
- encord/orm/dataset.py (15)
- tests/orm/test_create_dataset_response.py (1)
- tests/orm/test_dataset.py (1)
Files skipped from review due to trivial changes (1)
- tests/orm/test_create_dataset_response.py
Review comments generated (18)
- Review: 7
- LGTM: 11
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduction and Explanation
Implement the minimal "add existing items to a new dataset without re-uploading" thing. See also https://github.com/encord-team/cord-backend/pull/2665
Tests
Here: https://github.com/encord-team/cord-backend/pull/2670
Known issues
Will need the docs at some point, but probably only when we make this "really work"
Summary by CodeRabbit
New Features:
link_items
method to theDataset
andEncordClient
classes, enabling linking of existing items to a dataset without re-uploading.backing_folder_uuid
property to theDataset
class, providing the UUID of the associated backing folder.create_backing_folder
parameter in thecreate_dataset
function, allowing control over backing folder creation.get_datasets
function withenable_storage_api
flag for improved dataset retrieval.Tests:
backing_folder_uuid
field as a UUID.