Expose the 'data_hashes' filter on a dataset #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WalkthroughThe change introduces an optional Changes
NotesChat with
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
374
to
380
| if data_types is not None | ||
| else None, | ||
| "dataset_access_settings": dataclasses.asdict(self._dataset_access_settings), | ||
| "data_hashes": data_hashes, | ||
| }, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
The data_hashes parameter is directly added to the request payload without any null check. This could potentially send a None value in the request if data_hashes is not provided, which might not be handled correctly by the server and could lead to unexpected behavior or errors.
Suggested change
| if data_types is not None | |
| else None, | |
| "dataset_access_settings": dataclasses.asdict(self._dataset_access_settings), | |
| "data_hashes": data_hashes, | |
| }, | |
| ), | |
| ) | |
| if data_types is not None | |
| else None, | |
| "dataset_access_settings": dataclasses.asdict(self._dataset_access_settings), | |
| "data_hashes": data_hashes if data_hashes is not None else [], | |
| }, | |
| ), | |
| ) |
sergei-encord
approved these changes
Nov 1, 2023
Encord-davids
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
See https://github.com/encord-team/cord-backend/pull/2686
Summary by CodeRabbit
Release Notes
New Feature
data_hashesparameter to thelist_data_rowsfunction in the dataset module. This allows users to filter dataset rows based on a list of individual data unit hashes.