Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using dateutil
parse
method, which is cool, as it can correctly guess the data format and pretty error-tolerant.But this also makes parsing quite expensive, because in most of the cases date time is of correct known format.
So introducing a wrapper, that tries to parse known formats first, and fallbacks to the old behaviour only if necessary.
That provides up to 10x parsing speed improvement for usual case, while introducing only 1-2% overhead for cases that really need the more fault tolerant parsing.