Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement bundling to make it less cumbersome when applied in multiple places #480

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Reimplement bundling to make it less cumbersome when applied in multiple places #480

merged 2 commits into from
Dec 12, 2023

Conversation

sergei-encord
Copy link
Collaborator

Updating the way the bundling works, and add it to workflow_* and set_priority operations

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2023 •
edited
Loading

Unit test report

116 tests   115 ✔️  3s ⏱️
    1 suites      1 💤
    1 files        0 ❌

Results for commit 4032a06.

♻️ This comment has been updated with latest results.

rad-cord
rad-cord approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@rad-cord rad-cord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgotten how convoluted the bundling logic is 😬

I wonder if we can replace it with a long-lived connection instead

@sergei-encord sergei-encord merged commit 1186f54 into master Dec 12, 2023
3 checks passed
@sergei-encord sergei-encord deleted the bundle-priority-and-workflow-calls branch December 12, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rad-cord rad-cord rad-cord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergei-encord @rad-cord