Fix some minor typing issues #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rad-cord
approved these changes
May 21, 2024
MiloEnCord
reviewed
May 21, 2024
encord/dataset.py
Outdated
| @@ -260,7 +260,7 @@ def create_image_group( | |||
|
|
|||
| def create_dicom_series( | |||
| self, | |||
| file_paths: List[str], | |||
| file_paths: Union[List[str], List[Path], List[Union[Path, str]]], | |||
There was a problem hiding this comment.
s/List/Iterable/g if we're going for the most lenient definition for users convenience, like in the other method. Otherwise just Iterable[Path] instead of the whole union in both.
There was a problem hiding this comment.
Iterable makes sense and in the spirit of keeping it as flexible as possible. Can probably be Iterable[Union[Path,str]] (unless mypy throws a fit?)
sergei-encord
approved these changes
May 22, 2024
alexey-cord-tech
force-pushed
the
ak/typing-fixes
branch
from
dcac0f9 to
e71accc
Compare
Unit test report ((Pydantic 2.x)189 tests 189 ✅ 6s ⏱️ Results for commit e71accc. |
Unit test report (Pydantic 1.x)189 tests 189 ✅ 5s ⏱️ Results for commit e71accc. |
SDK integration test report271 tests 271 ✅ 23m 58s ⏱️ Results for commit e71accc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
A little tidy-up so that we can declare it
py.typedand have thesdk_integration_testsbe properly typed, too.Known issues
There are some unfixable-ish issues anyway, but let's fix what's easy to fix.