-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC-3689 COCO Exporter #602
Conversation
Unit test report (Pydantic 1.x)195 tests 195 ✅ 5s ⏱️ Results for commit 68ee994. ♻️ This comment has been updated with latest results. |
Unit test report ((Pydantic 2.x)195 tests 195 ✅ 6s ⏱️ Results for commit 68ee994. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested it against Bitmasks?
have you tested it against loads of things?
SDK can't really afford to be wrong client side which is why there was pushback for server side previously
3855df6
to
2498cc6
Compare
SDK integration test report279 tests 272 ✅ 17m 36s ⏱️ Results for commit 2498cc6. |
2498cc6
to
68ee994
Compare
Introduction and Explanation
COCO Exporter. Directly pulling code from BE and swapping out models to use SDK side models. Wired into project.export_label_rows_to_COCO.
JIRA
https://linear.app/encord/issue/EC-3689/coco-exporter-and-importer-for-sdk
Documentation
This will require documentation and the function itself should require a docstring.
Tests
Small unit test included on this side. Can also include an integration test of project method in BE.
Known issues
Open for debate around location of code and interface implementation.
MAJOR Dependencies introduced: I just followed the BE code which includes a dependency on pycocotools and on Shapely. pycocotools probably necessary and not that large. Conceptually Shapely could be worked around but this is a moderate sized dependency so should be considered.