Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC-3689 COCO Exporter #602

Merged
merged 2 commits into from
Jan 8, 2025
Merged

EC-3689 COCO Exporter #602

merged 2 commits into from
Jan 8, 2025

Conversation

Jim-Encord
Copy link
Contributor

Introduction and Explanation

COCO Exporter. Directly pulling code from BE and swapping out models to use SDK side models. Wired into project.export_label_rows_to_COCO.

JIRA

https://linear.app/encord/issue/EC-3689/coco-exporter-and-importer-for-sdk

Documentation

This will require documentation and the function itself should require a docstring.

Tests

Small unit test included on this side. Can also include an integration test of project method in BE.

Known issues

Open for debate around location of code and interface implementation.
MAJOR Dependencies introduced: I just followed the BE code which includes a dependency on pycocotools and on Shapely. pycocotools probably necessary and not that large. Conceptually Shapely could be worked around but this is a moderate sized dependency so should be considered.

@Jim-Encord Jim-Encord requested a review from sergei-encord May 31, 2024 12:37
Copy link

github-actions bot commented Dec 16, 2024

Unit test report (Pydantic 1.x)

195 tests   195 ✅  5s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 68ee994.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 16, 2024

Unit test report ((Pydantic 2.x)

195 tests   195 ✅  6s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 68ee994.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@Jim-Encord Jim-Encord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it against Bitmasks?
have you tested it against loads of things?
SDK can't really afford to be wrong client side which is why there was pushback for server side previously

pyproject.toml Show resolved Hide resolved
encord/utilities/coco/exporter.py Show resolved Hide resolved
encord/utilities/coco/exporter.py Show resolved Hide resolved
encord/utilities/coco/exporter.py Outdated Show resolved Hide resolved
@Jim-Encord Jim-Encord force-pushed the jb/COCO_exporter_sdk branch from 3855df6 to 2498cc6 Compare January 3, 2025 11:32
Copy link

github-actions bot commented Jan 3, 2025

SDK integration test report

279 tests   272 ✅  17m 36s ⏱️
  1 suites    7 💤
  1 files      0 ❌

Results for commit 2498cc6.

@Jim-Encord Jim-Encord force-pushed the jb/COCO_exporter_sdk branch from 2498cc6 to 68ee994 Compare January 8, 2025 11:46
@Jim-Encord Jim-Encord merged commit 8d44e08 into master Jan 8, 2025
5 of 6 checks passed
@Jim-Encord Jim-Encord deleted the jb/COCO_exporter_sdk branch January 8, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants