Datasets list API v2 - SDK #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jim-Encord
reviewed
Nov 20, 2024
| @@ -253,24 +255,43 @@ def get_datasets( | |||
| Returns: | |||
| list of (role, dataset) pairs for datasets matching filter conditions. | |||
| """ | |||
| properties_filter = self.__validate_filter(locals()) | |||
There was a problem hiding this comment.
Love seeing this hack die 😍
alexey-cord-tech
force-pushed
the
aj/datasets-list-api-v2
branch
from
70b8f47 to
799a7be
Compare
alexey-cord-tech
approved these changes
Dec 5, 2024
alexey-cord-tech
force-pushed
the
aj/datasets-list-api-v2
branch
from
34fe5e5 to
a943321
Compare
Unit test report (Pydantic 1.x)189 tests 189 ✅ 5s ⏱️ Results for commit db2ce1e. |
Unit test report ((Pydantic 2.x)189 tests 189 ✅ 6s ⏱️ Results for commit db2ce1e. |
SDK integration test report270 tests 270 ✅ 24m 50s ⏱️ Results for commit db2ce1e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datasets list API v2 - SDK