feat: load an audio sdk object class label row [merge waiting on PR to prod] #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-encord
changed the title
Unit test report (Pydantic 1.x)193 tests 193 ✅ 6s ⏱️ Results for commit 23f4aac. ♻️ This comment has been updated with latest results. |
Unit test report ((Pydantic 2.x)193 tests 193 ✅ 6s ⏱️ Results for commit 23f4aac. ♻️ This comment has been updated with latest results. |
james-encord
changed the title
james-encord
changed the title
Jim-Encord
reviewed
Dec 4, 2024
| "Classification.create_instance(range_only=True) to achieve this." | ||
| ) | ||
|
|
||
| def is_range_only(self) -> bool: |
There was a problem hiding this comment.
Could also be a property?
There was a problem hiding this comment.
keeping consistent with classification interface.
clinton-encord
approved these changes
Dec 5, 2024
james-encord
changed the title
james-encord
force-pushed
the
jsc/feat/audio-sdk
branch
from
047227e to
0ad5a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
Extend audio SDK support from just audio classifications to audio objects as well.
Currently still work-in-progress, successfully passes test to load audio objects from test project on dev, still need to test all attributes are loaded correctly and non-standard attribute support & saving.
Note: merging
Need a recent PR for lastEditedBy handling on save to hit prod before merging